-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This was initially running into an error because, I had been sloppy with the .gitignore and added 'dist' instead of '/dist'. Apparently .npmignore defaults to .gitignore if, so `node_modules/electron/resources/dist` was invisible to `npm rebuild`. Luckily I googled/guessed that quickly.
@GabeIsman, you are a hero! 🏅 Confirmed that .deb packages now run when building off this branch. A few questions:
Unfortunately there are still regressions at work: we lost the newer assets original presented in #17. Since having working builds again is vital to debugging the assets regression, I'm inclined to merge here and open separate tickets for fixing the assets. As soon as you confirm can address the questions above, I'm fine with merge here. |
Regarding asset regressions, looks like those are resolved in #24. This PR still needs to be merged in order to fix builds under Linux, but interested in @GabeIsman's thoughts on items 1-3 above. |
@conorsch Great points on all 3! They rusty-secrets version in the root package.json is only used for integration testing, but should definitely be kept in sync. Really we should merge the two package.json's so we don't have to worry about keeping that and the application version in sync between the two. Thank you for testing this so thoroughly. I was assuming all yesterday that #17 just wasn't merged but then it hit me sometime today that it had been. I'm glad you were able to sort out what went wrong! |
Thanks @GabeIsman! Your updates look great. 🎊 |
Fixes #20 🎊.
make clean-build
produces a working .deb.The global installs can be deleted because npm adds
./node_modules/.bin
to the path for anynpm run ...
commands.The
build-app
command can be deleted because I made it a part ofdist
a while back.There were really three compounding issues here:
node-sass
built for the wrong node bindings (I really don't know why, when they are installed from scratch).npm rebuild
is just the magic dust you have to sprinkle everywhere to make npm behave itself..gitignore
on my part was causingnpm rebuild
to fail.I'll go ahead and the honorary problem that freaking webpack thinks missing modules are not a good enough reason to return a nonzero exit code.