App still uses default Electron icon

[conorsch]

Despite new asset changes in #17, the built application still uses the default app icon for Electron:

Output of npm run dist on Mac includes:

⚠️ Application icon is not set, default Electron icon will be used

Notably that message does not display when building under Linux (including changes proposed in #22), but I also don't see a custom icon under Linux:

So looks like we have some pathing issues to sort out. Will hit the docs.

[conorsch]

Applying this diff removes the warning on Mac builds:

diff --git a/package.json b/package.json
index 21c409e..4f9a7e6 100644
--- a/package.json
+++ b/package.json
@@ -27,6 +27,9 @@
     "linux": {
       "icon": "build/icons/",
       "target": ["deb"]
+    },
+    "mac": {
+      "icon": "build/icons/app.icns"
     }
   },
   "bin": {

but the icon does not change. Quoth the docs:

The path to icon (.icns for MacOS and .ico for Windows), relative to build (build resources directory).

So likely a simple pathing problem.

[conorsch]

The diff above seems to be what we want. The changes in #17 provided a Sunder-specific app icon (3457a3b), but that file is no longer in master. Must have been a mistake caused by my resolution of merge conflicts between #16 and #17.

Will try to pluck out of history and add again.

[GabeIsman]

Is this diff still necessary? The Mac icon was working for me on #17 without. That is, I think build/icons/app.icns is the default location that electron-builder looks. Wouldn't hurt to be explicit of course!

[conorsch]

@GabeIsman No, the diff above is superseded entirely by #24, which solves the real porblem, which was I screwed up a complicated merge and rewound the clock on your asset integration.

[GabeIsman]

Gotcha. Closing this one then!

[conorsch]

Still an issue on Linux—it's a quick fix, PR incoming.