This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Fixes app logo for Linux builds #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `icns2png` command was referencing the old path to the `app.icns` file, which is no longer valid as of #17 and #24. Fixing that command allows the icns -> png format conversion work as intended. No changes required to `package.json`, since the paths there are already correct. Closes #23. Signed-off-by: Conor Schaefer <conor@freedom.press>
|
Good catch. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
icns2pngcommand was referencing the old path to theapp.icnsfile, which is no longer valid as of #17 and #24. Fixing that command
allows the icns -> png format conversion work as intended. No changes
required to
package.json, since the paths there are already correct.Closes #23.
Signed-off-by: Conor Schaefer conor@freedom.press
Behold:
Run a
make clean-buildto take advantage of the changes, otherwise the old PNGs will still be used.