ipatests: keep default log level for 389-ds

[nicki-krizek]

The log level of 8192 for 389-ds is very noisy and conceals useful debug
messages. The default log level 0 should be sufficient for our purposes.

Part of: https://pagure.io/freeipa/issue/7162
Signed-off-by: Tomas Krizek tkrizek@redhat.com

[nicki-krizek]

@tbordaz Could you please review/ack? You can check any of the ds logs and verify the debug messages aren't there.

[tbordaz]

The patch is fine to me. It could be an option (to keep good code) to change enable_replication_debugging into a generic function taking a log-level in param. Then calling it with level 0.

[nicki-krizek]

I agree it's better to keep the code. I've changed to PR to use log_level of 0 by default, but left the option to change it.

[rcritten]

LGTM too

[nicki-krizek]

For some reason, it doesn't work properly. The replication messages are still in the ds error log, for example, see https://fedorapeople.org/groups/freeipa/prci/jobs/2df3b8ee-9eaa-11e7-8c70-fa163e566bda/test_integration-test_simple_replication.py-TestSimpleReplication--test_user_replication_to_replica/master.ipa.test/var/log/dirsrv/slapd-IPA-TEST/errors.gz

[Firstyear]

Hmmm, maybe there is a test elsewhere that is causing this change? It looks like the loglevel is set correctly and the server initial is not logging, but suddenly it changes. You could use the DS audit log to try and track who triggered the change of the loglevel, but I think this patch and what it is "now" is good to merge.

[nicki-krizek]

Based on comments above, I'm re-adding the ack. I'll keep the ticket open until the replication messages are no longer in ds log.

[nicki-krizek]

master:

• be6f1a6 ipatests: set default 389-ds log level to 0