Provide ldap_uri in Custodia uninstaller #1776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
issue7474_custodia_ldap_uri
branch
from
0fdae20
to
0285760
Compare
|
Is this the agreed approach, @tiran @felipevolpone? i.e. should #1772 be closed? |
|
@frasertweedale yes, that's my plan. @felipevolpone 's patch fixes the issue, too. But his approach may also hide a bug in the configuration. |
Without ldap_uri, IPAKEMKeys parses /etc/ipa/default.conf. During uninstallation, the file may no longer contain ldap_uri. This workaround is required for test case test_replica_promotion.py::TestReplicaPromotionLevel0::test_promotion_disabled Fixes: https://pagure.io/freeipa/issue/7474 Co-authored-by: Felipe Barreto <fbarreto@redhat.com> Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
issue7474_custodia_ldap_uri
branch
from
0285760
to
21ce0de
Compare
|
Did an install and uninstallation, no worries. All the tests are passing and the code looks fine so here's my ACK. |
|
master:
|
This was referenced Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without ldap_uri, IPAKEMKeys parses /etc/ipa/default.conf. During
uninstallation, the file may no longer contain ldap_uri. This workaround
is required for test case
test_replica_promotion.py::TestReplicaPromotionLevel0::test_promotion_disabled
Fixes: https://pagure.io/freeipa/issue/7474
Co-authored-by: Felipe Barreto fbarreto@redhat.com
Signed-off-by: Christian Heimes cheimes@redhat.com
Alternative solution for #1772