Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test fix] Fix trust tests for Posix Support #1840

Closed
wants to merge 1 commit into from
Closed

[Test fix] Fix trust tests for Posix Support #1840

wants to merge 1 commit into from

Conversation

gkaihorodova
Copy link
Contributor

@gkaihorodova gkaihorodova commented Apr 20, 2018 •
edited by tiran
Loading

Test ecxpects auto-detection of trust type, Windows Server 2016 doesn't have
support for MFU/NIS (SFU - Services for Unix), so auto detection doesn't work

Fix is to pass extra arguments to the trust-add command,
such as --range-type="ipa-ad-trust-posix" to enforce a particular range type

https://pagure.io/freeipa/issue/7508

@abbra
Copy link
Contributor

abbra commented Apr 20, 2018

Couple comments:

  • Travis-CI build fail due to PEP8 errors:
PEP-8 errors:
./ipatests/test_integration/test_trust.py:213:13: E128 continuation line under-indented for visual indent
  • Please remove the comment above the line you replaced as it says we aren't adding --range-type directly but we are adding it now.

@gkaihorodova
Copy link
Contributor Author

Hello!
Thank you @abbra for taking a look and comments.

@slaykovsky slaykovsky added the re-run Trigger a new run of PR-CI label Apr 23, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Apr 23, 2018
@gkaihorodova
[Test fix] Fix trust tests for Posix Support
892d70c 
Test ecxpects auto-detection of trust type, Windows Server 2016 doesn't have
support for MFU/NIS (SFU - Services for Unix), so auto detection doesn't work
Fix is to pass extra arguments to the trust-add command,
such as --range-type="ipa-ad-trust-posix" to enforce a particular range type

https://pagure.io/freeipa/issue/7508
@slaykovsky slaykovsky added the re-run Trigger a new run of PR-CI label Apr 23, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Apr 23, 2018
@slaykovsky slaykovsky added the re-run Trigger a new run of PR-CI label Apr 23, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Apr 23, 2018
@gkaihorodova gkaihorodova added the needs review Pull Request is waiting for a review label Apr 25, 2018
@tiran tiran requested a review from abbra April 25, 2018 08:30
@abbra
Copy link
Contributor

abbra commented Apr 25, 2018

LGTM.

@abbra abbra added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Apr 25, 2018
@tiran tiran added the pushed Pull Request has already been pushed label Apr 25, 2018
@tiran
Copy link
Member

tiran commented Apr 25, 2018

master:

  • 5165afd Fix trust tests for Posix Support

@tiran tiran closed this Apr 25, 2018
This was referenced Apr 25, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbra abbra Awaiting requested review from abbra

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gkaihorodova @abbra @tiran @slaykovsky @freeipa-pr-ci