Install shared templates for client setup too #1931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeipa.template should be packaged in freeipa-client-common
The rest of templates in /usr/share/ipa should go to freeipa-server-common
Fenerate file with server templates via find. Since we only need those
at /usr/share/ipa and not in subfolders, synthesize whole path based
on the name. This also gives us an easier way to get rid of the
%{buildroot} prefix.
Use -f option to %files to pass server templates file
FreeIPA has two major build modes and this affects how content from install/share is handled: - server build: everything from install/share is installed - client build: only selected templates from install/share are installed This change is needed to allow us reusing the same krb5.conf snippets for both builds right now.
|
Pushed an update that should make tox targets work again. |
frozencemetery
approved these changes
May 16, 2018
|
Chose #1953 in favor of this one, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset updates a spec file and our Make files to allow installing shared templates for the client build as well. So far we only have a single template for krb5.conf.d (freeipa.template) but there might be potentially more coming in.
This is a proper solution -- in Fedora 28/29 builds downstream I'm copying the files manually to avoid re-spinning a tarball with 4.7.0rc2. We still need to filter out client side templates from the server side in the spec file, so there is not a single place to define all files, unfortunately, but that's good enough for now as we have only a single file used by the client side.