ipa vault-archive overwrites an existing value without warning #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasertweedale
requested changes
May 20, 2018
ipaserver/plugins/vault.py
Outdated
| Vault is a secure place to store a secret. | ||
| Vault is a secure place to store a secret. One vault can only | ||
| store one secret. Contents of vault would be overwritten if | ||
| at all present. |
There was a problem hiding this comment.
I suggest a small tweak to the text for clarify: instead of Contents of vault would be overwritten if at all present,
perhaps When archiving a secret in a vault, the existing secret (if any) is overwritten.
Otherwise, ACK.
Upstream ticket was raised for issuing an warning message whenever data in ipa vault is overwritten. In Bugzilla(1339129) its agreed upon that Current behavior is consistent with other IPA commands. None of ipa mod commands asks for confirmation and therefore it should be the same here. But to document, that vault can contain only one value in ipa help vault. This PR addresses the changes agreed in Bugzilla. Resolves: https://pagure.io/freeipa/issue/5922
|
@frasertweedale Done Changes. Thanks. |
|
LGTM but leaving final approval to Fraser. |
|
Thanks @amitkumar50. ACK! |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream ticket was raised for issuing an warning message
whenever data in ipa vault is overwritten.
In Bugzilla(1339129) its agreed upon that Current behavior is consistent
with other IPA commands. None of ipa mod commands asks for confirmation
and therefore it should be the same here.
But to document, that vault can contain only one value in ipa help vault.
This PR addresses the changes agreed in Bugzilla.
Resolves: https://pagure.io/freeipa/issue/5922