Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] ipa vault-archive overwrites an existing value without warning #1955

Closed

Conversation

flo-renaud
Copy link
Contributor

@flo-renaud flo-renaud commented May 22, 2018

This PR was opened automatically because PR #1948 was pushed to master and backport to ipa-4-6 is required.

Upstream ticket was raised for issuing an warning message
whenever data in ipa vault is overwritten.

In Bugzilla(1339129) its agreed upon that Current behavior is consistent
with other IPA commands. None of ipa mod commands asks for confirmation
and therefore it should be the same here.
But to document, that vault can contain only one value in ipa help vault.

This PR addresses the changes agreed in Bugzilla.

Resolves: https://pagure.io/freeipa/issue/5922
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label May 22, 2018
@flo-renaud
Copy link
Contributor Author

PR was ACKed automatically because this is backport of PR #1948. Wait for CI to finish before pushing. In case of questions or problems contact @amitkumar50 who is author of the original PR.

@flo-renaud
Copy link
Contributor Author

ipa-4-6:

  • 9864ea2 ipa vault-archive overwrites an existing value without warning

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label May 23, 2018
@flo-renaud flo-renaud closed this May 23, 2018
@flo-renaud flo-renaud deleted the backport_pr1948_ipa-4-6 branch June 19, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
1 participant