Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making nigthly test definition editable by FreeIPA's contributors #2139

Closed
wants to merge 3 commits into from
Closed

Making nigthly test definition editable by FreeIPA's contributors #2139

wants to merge 3 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 11, 2018 •
edited by Rezney

Now the test definition of nightly tests will be on freeipa repo. The
definition that's used on every PR (previously as .freeipa-pr-ci.yaml)
is in ipatests/prci_definitions/gating and the .freeipa-pr-ci.yaml file
is just a symlink to the real file.

In the same dir there is also nightly_master and nightly_rawhide, both
to be used in nightly tests.

This PR is the result of discussion on freeipa-devel mailing list [1].

[1] https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/4VAWJ4SFKKBFFICDLQCTXJWRRQHIYJLL

Also in the PR:

  • Fix topology configuration of nightly runs
  • Add convenient template for temp commits

PR replaces #1957

@tiran tiran mentioned this pull request Jul 11, 2018
Closed
@tiran
Copy link
Member Author

tiran commented Jul 11, 2018

The change also depends on freeipa/freeipa-pr-ci#201

@Rezney
Copy link
Collaborator

Rezney commented Jul 17, 2018

freeipa/freeipa-pr-ci#201 was pushed. The patch looks good to me. Lets push it together with introducing #201 into production. Cheers!

@Rezney Rezney self-assigned this Jul 17, 2018
@Rezney
Copy link
Collaborator

Rezney commented Jul 19, 2018

@tiran Could you please divide topology tests in the nightly definition into:

  fedora-28/test_topology_TestCASpecificRUVs:
    requires: [fedora-28/build]
    priority: 50
    job:
      class: RunPytest
      args:
        build_url: '{fedora-28/build_url}'
        test_suite: test_integration/test_topology.py::TestCASpecificRUVs
        template: *ci-master-f28
        timeout: 7200
        topology: *master_3repl_1client

  fedora-28/test_topology_TestTopologyOptions:
    requires: [fedora-28/build]
    priority: 50
    job:
      class: RunPytest
      args:
        build_url: '{fedora-28/build_url}'
        test_suite: test_integration/test_topology.py::TestTopologyOptions
        template: *ci-master-f28
        timeout: 7200
        topology: *master_3repl_1client

  fedora-28/test_topology_TestReplicaManageDel:
    requires: [fedora-28/build]
    priority: 50
    job:
      class: RunPytest
      args:
        build_url: '{fedora-28/build_url}'
        test_suite: test_integration/test_topology.py::TestReplicaManageDel
        template: *ci-master-f28
        timeout: 7200
        topology: *master_3repl_1client

And also raise template version from 1.0.5 to 1.0.6 please.

Thank you very much...

Felipe Barreto and others added 2 commits July 24, 2018 12:04
@Tiboris
Making nigthly test definition editable by FreeIPA's contributors
ac23ec5 
Now the test definition of nightly tests will be on freeipa repo. The
definition that's used on every PR (previously as .freeipa-pr-ci.yaml)
is in ipatests/prci_definitions/gating and the .freeipa-pr-ci.yaml file
is just a symlink to the real file.

In the same dir there is also nightly_master and nightly_rawhide, both
to be used in nightly tests.

Divided test_topology.py into 3 subtests.

Bumped vagrant template to version 0.1.6

This PR is the result of discussion on freeipa-devel mailing list [1].

[1] https://lists.fedoraproject.org/archives/list/freeipa-devel@lists.fedorahosted.org/message/4VAWJ4SFKKBFFICDLQCTXJWRRQHIYJLL/
@tiran @Tiboris
Fix topology configuration of nightly runs
509288f 
Some nightly runs didn't have enough resources configured.

See: https://pagure.io/freeipa/issue/7638
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@Tiboris Tiboris force-pushed the nightlies_tests_editable_2 branch from e03ed11 to 575b6d1 Compare July 24, 2018 10:05
@Tiboris
Copy link
Member

Tiboris commented Jul 24, 2018

@Rezney I have updated topology tests.

@Tiboris Tiboris force-pushed the nightlies_tests_editable_2 branch from 575b6d1 to 5908169 Compare July 24, 2018 10:09
@Tiboris Tiboris added the needs review Pull Request is waiting for a review label Jul 24, 2018
@tiran @Tiboris
Add convenient template for temp commits
6ea73b3 
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@Tiboris Tiboris force-pushed the nightlies_tests_editable_2 branch from 5908169 to 6ea73b3 Compare July 26, 2018 08:14
@Rezney Rezney added the re-run Trigger a new run of PR-CI label Jul 26, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 26, 2018
@Rezney Rezney added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Jul 26, 2018
@Rezney
Copy link
Collaborator

Rezney commented Jul 27, 2018

master:

  • 8f202bb Making nigthly test definition editable by FreeIPA's contributors
  • 6212423 Fix topology configuration of nightly runs
  • 8edde14 Add convenient template for temp commits

@Rezney Rezney added the pushed Pull Request has already been pushed label Jul 27, 2018
@Rezney Rezney closed this Jul 27, 2018
@Rezney Rezney mentioned this pull request Jul 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rezney Rezney

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@tiran @Rezney @Tiboris @freeipa-pr-ci