Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_cli_fsencoding on Python 3.7, take 2 #2532

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 7, 2018

0a5a7bd introduced another problem. The
test is now failing on systems without a full IPA client or server
installation. Use IPA_CONFDIR env var to override location of
default.conf, so that the command always fails.

Signed-off-by: Christian Heimes cheimes@redhat.com

0a5a7bd introduced another problem. The
test is now failing on systems without a full IPA client or server
installation. Use IPA_CONFDIR env var to override location of
default.conf, so that the command always fails.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added needs review Pull Request is waiting for a review ipa-4-7 re-run Trigger a new run of PR-CI labels Nov 7, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Nov 8, 2018
Copy link
Contributor

@serg-cymbaluk serg-cymbaluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (both 3.6 and 3.7)

@serg-cymbaluk serg-cymbaluk added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Nov 8, 2018
@tiran tiran added the pushed Pull Request has already been pushed label Nov 8, 2018
@tiran
Copy link
Member Author

tiran commented Nov 8, 2018

master:

  • e569afb Fix test_cli_fsencoding on Python 3.7, take 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants