Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded instances of /var/lib/ipa/backup/ #3113

Closed
wants to merge 1 commit into from
Closed

Remove hardcoded instances of /var/lib/ipa/backup/ #3113

wants to merge 1 commit into from

Conversation

fcami
Copy link
Contributor

@fcami fcami commented May 3, 2019 •
edited
Loading

/var/lib/ipa/backup/ is defined in ipaplatform.paths as paths.IPA_BACKUP_DIR
Remove all instances of the hardcoded string in ipa_backup.py.

Signed-off-by: François Cami fcami@redhat.com

@fcami fcami added ipa-4-7 WIP Work in progress - not ready yet for review re-run Trigger a new run of PR-CI labels May 3, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label May 3, 2019
@fcami
ipa_backup.py: replace /var/lib/ipa/backup with paths.IPA_BACKUP_DIR
ee1a62c 
/var/lib/ipa/backup is defined in ipaplatform.paths as paths.IPA_BACKUP_DIR
Remove all instances of /var/lib/ipa/backup/ in ipa_backup.py.

Signed-off-by: François Cami <fcami@redhat.com>
@fcami fcami added needs review Pull Request is waiting for a review and removed WIP Work in progress - not ready yet for review labels May 6, 2019
@flo-renaud
Copy link
Contributor

Hi @fcami,
thanks for the cleanup, LGTM. As it is a simple fix, no need for any pagure ticket.
Can you remove the temp commit and I will ACK when PR-CI passes?

@flo-renaud flo-renaud removed the needs review Pull Request is waiting for a review label May 6, 2019
@flo-renaud flo-renaud self-assigned this May 6, 2019
@fcami fcami added WIP Work in progress - not ready yet for review and removed WIP Work in progress - not ready yet for review labels May 6, 2019
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label May 7, 2019
@fcami
Copy link
Contributor Author

fcami commented May 7, 2019

Thanks @flo-renaud

@fcami fcami added the pushed Pull Request has already been pushed label May 7, 2019
@fcami
Copy link
Contributor Author

fcami commented May 7, 2019

master:

  • 5331510 ipa_backup.py: replace /var/lib/ipa/backup with paths.IPA_BACKUP_DIR

@fcami fcami closed this May 7, 2019
@fcami fcami mentioned this pull request May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flo-renaud flo-renaud

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fcami @flo-renaud @freeipa-pr-ci