Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform baseline healthcheck #4323

Closed
wants to merge 1 commit into from
Closed

Perform baseline healthcheck #4323

wants to merge 1 commit into from

Conversation

rcritten
Copy link
Contributor

@rcritten rcritten commented Mar 8, 2020

Run healthcheck on a default installation and ensure that there
are no failures. This test ensures that a fresh IPA installation
will pass healthcheck.

https://bugzilla.redhat.com/show_bug.cgi?id=1774032

@rcritten rcritten added the ipa-4-8 Mark for backport to ipa 4.8 label Mar 8, 2020
@ssidhaye
Copy link
Contributor

ssidhaye commented Mar 12, 2020 •
edited
Loading

@rcritten Thanks for the patch. Should we check if the output contains
Missing tracking for cert-database or Unknown certmonger id.
Otherwise the patch looks good.

@rcritten
Copy link
Contributor Author

I don't think we need to explicitly check for this specific error. This baseline test will ensure that no errors at all are returned on a default installation which also covers the specific problem raised in the BZ.

@ssidhaye ssidhaye added the ack Pull Request approved, can be merged label Mar 13, 2020
@flo-renaud
Copy link
Contributor

Hi @rcritten
tests are green, please remove the temp commit.

@rcritten
Copy link
Contributor Author

This doesn't require a rebase but PR #3645 added a new way to execute the test so I'm going to migrate to that method. I need to get PR #4317 merged first.

Removing ack for now.

@rcritten rcritten removed the ack Pull Request approved, can be merged label Mar 13, 2020
@freeipa-pr-ci freeipa-pr-ci added the needs rebase Pull Request cannot be automatically merged - needs to be rebased label Mar 31, 2020
@rcritten rcritten added rejected Pull Request has been rejected re-run Trigger a new run of PR-CI and removed needs rebase Pull Request cannot be automatically merged - needs to be rebased rejected Pull Request has been rejected labels Apr 1, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Apr 1, 2020
@rcritten
Copy link
Contributor Author

rcritten commented Apr 1, 2020

Tests passing after much flag issues. Adding back ack and pushing.

@rcritten
Copy link
Contributor Author

rcritten commented Apr 1, 2020

Hang on, probably worth re-review since I rebased and made another slight change, adding back needs_review.

@rcritten rcritten added the needs review Pull Request is waiting for a review label Apr 1, 2020
flo-renaud
flo-renaud reviewed Apr 2, 2020
View reviewed changes
ipatests/test_integration/test_ipahealthcheck.py Outdated
@@ -387,6 +392,20 @@ def test_source_ipa_roles_check_crlmanager(self):
assert check["result"] == "SUCCESS"
assert check["kw"]["key"] == "crl_manager"
assert check["kw"]["crlgen_enabled"] is False
self.master.run_command(["ipa-crlgen-manage", "enable"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this command in a finally: block to make sure it is called even if the test fails.

@rcritten
Copy link
Contributor Author

rcritten commented Apr 2, 2020

I implemented it as a fixture

@freeipa-pr-ci freeipa-pr-ci added the needs rebase Pull Request cannot be automatically merged - needs to be rebased label Apr 3, 2020
@rcritten rcritten mentioned this pull request Apr 3, 2020
Closed
@rcritten rcritten removed the needs rebase Pull Request cannot be automatically merged - needs to be rebased label Apr 3, 2020
@rcritten
Perform baseline healthcheck
1c9cb8c 
Run healthcheck on a default installation and ensure that there
are no failures. This test ensures that a fresh IPA installation
will pass healthcheck.

https://bugzilla.redhat.com/show_bug.cgi?id=1774032
@flo-renaud
Copy link
Contributor

Hi @rcritten
thanks for the updated patch, LGTM and tests are green. Please remove the temp commit and I will ack.

@flo-renaud flo-renaud self-assigned this Apr 6, 2020
@flo-renaud flo-renaud added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Apr 6, 2020
@rcritten rcritten added the pushed Pull Request has already been pushed label Apr 6, 2020
@rcritten
Copy link
Contributor Author

rcritten commented Apr 6, 2020

master:

  • 3022bb5 Perform baseline healthcheck

@rcritten rcritten closed this Apr 6, 2020
@rcritten rcritten mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-renaud flo-renaud flo-renaud left review comments

Assignees

@flo-renaud flo-renaud

Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcritten @ssidhaye @flo-renaud @freeipa-pr-ci