Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /run and /run/lock instead of /var #4533

Closed
wants to merge 1 commit into from
Closed

Use /run and /run/lock instead of /var #4533

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Apr 15, 2020

Fixes: https://pagure.io/freeipa/issue/8272
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran added trivial needs review Pull Request is waiting for a review ipa-4-8 Mark for backport to ipa 4.8 labels Apr 15, 2020
@tiran tiran mentioned this pull request Apr 15, 2020
Closed
@stanislavlevin
Copy link
Contributor

Hi, @tiran.
What is about:

$ git grep 'localstatedir.*/run'

daemons/dnssec/ipa-ods-exporter.socket.in:ListenStream=@localstatedir@/run/opendnssec/engine.sock
daemons/ipa-kdb/Makefile.am:    -DLDAPIDIR=\""$(localstatedir)/run"\"           \
daemons/ipa-sam/Makefile.am:    -DLDAPIDIR=\""$(localstatedir)/run"\"           \
server.m4:krb5rundir="${localstatedir}/run/krb5kdc"

@tiran
Use /run and /run/lock instead of /var
f1d34d0 
Also add runstatedir autoconf var. IPA requires autoconf 2.59. The
variable will be available with autoconf 2.70.

Fixes: https://pagure.io/freeipa/issue/8272
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran closed this Apr 15, 2020
@tiran tiran reopened this Apr 15, 2020
@tiran
Copy link
Member Author

tiran commented Apr 15, 2020

@stanislavlevin Good catch! runstatedir is not yet available in our autoconf versions. I have added it to configure.ac

@abbra
Copy link
Contributor

abbra commented Apr 15, 2020

LGTM. Thanks for fixing this old-standing issue. ;)

@abbra abbra added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Apr 15, 2020
@tiran tiran added the pushed Pull Request has already been pushed label Apr 15, 2020
@tiran
Copy link
Member Author

tiran commented Apr 15, 2020

master:

  • bdf1137 Use /run and /run/lock instead of /var

@tiran tiran closed this Apr 15, 2020
@tiran tiran mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed trivial
Projects
None yet
Milestone
No milestone
3 participants
@tiran @stanislavlevin @abbra