[Backport][ipa-4-8] ipatests: fix race condition in finalizer of encrypted backup test #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
When using a fixture, we get a temporary directory created and then removed by pytest. Pytest uses `shutil.rmtree` call which collects all files in the directory being removed and then removes them one by one. At the point of removal of our GNUPGHOME directory, gpg daemon is being shut down and there might still be an agent UNIX domain socket. The removal actually overlaps in time with shut down of the gpg daemon, thus causing `shutil.rmtree()` to fail when an agent UNIX domain socket is removed by the daemon. Change the way how we run the gpg agent to use a temporary systemd service. Stop the service in the finalizer method so that systemd would send SIGTERM signal and the gpg agent would clean itself up. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #5373 was pushed to master and backport to ipa-4-8 is required.