Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-8] Include the CA profile when modifying request in ipa_certupdate #5404

Closed

Conversation

flo-renaud
Copy link
Contributor

This PR was opened automatically because PR #5393 was pushed to master and backport to ipa-4-8 is required.

The CA tracking request is modified (it calls renew but it doesn't
actually do a renewal) as part of ipa-certupdate and it dropped
the profile. ipa-healthcheck discovered this condition.

https://pagure.io/freeipa/issue/8644

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
The CA tracking request was modified to drop the profile which
was caught by ipa-healthcheck. Run ipa-certupdate then
ipa-healthcheck to confirm that no problems are introduced.

https://pagure.io/freeipa/issue/8644

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Jan 7, 2021
@flo-renaud
Copy link
Contributor Author

PR was ACKed automatically because this is backport of PR #5393. Wait for CI to finish before pushing. In case of questions or problems contact @rcritten who is author of the original PR.

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Jan 7, 2021
@flo-renaud
Copy link
Contributor Author

ipa-4-8:

  • f2fecbd Don't change the CA profile when modifying request in ipa_certupdate
  • 42bdcfb ipatests: test that no errors are reported after ipa-certupdate

@flo-renaud flo-renaud closed this Jan 7, 2021
@flo-renaud flo-renaud deleted the backport_pr5393_ipa-4-8 branch January 7, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants