Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][ipa-4-8] Include the CA profile when modifying request in ipa_certupdate #5404

Closed
wants to merge 2 commits into from
Closed

[Backport][ipa-4-8] Include the CA profile when modifying request in ipa_certupdate #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
483ccc0
Don't change the CA profile when modifying request in ipa_certupdate
rcritten Jan 4, 2021
eeb78ea
ipatests: test that no errors are reported after ipa-certupdate
rcritten Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipaclient/install/ipa_certupdate.py
View file
Open in desktop
Expand Up @@ -171,7 +171,7 @@ def update_server(certs):
#
logger.debug("resubmitting certmonger request '%s'", request_id)
certmonger.resubmit_request(
request_id, ca='dogtag-ipa-ca-renew-agent-reuse', profile='')
request_id, ca='dogtag-ipa-ca-renew-agent-reuse')
try:
state = certmonger.wait_for_request(request_id, timeout)
except RuntimeError:
Expand Down
14 changes: 14 additions & 0 deletions ipatests/test_integration/test_ipahealthcheck.py
View file
Open in desktop
Expand Up @@ -280,6 +280,20 @@ def test_human_output(self, restart_service):
assert output == \
"ERROR: ipahealthcheck.meta.services.sssd: sssd: not running"

def test_ipa_healthcheck_after_certupdate(self):
"""
Verify that ipa-certupdate hasn't messed up tracking

ipa-certupdate was dropping the profile value from the CA
signing cert tracking. ipa-healthcheck discovered this.

Run ipa-healthcheck after ipa-certupdate to ensure that
no problems are discovered.
"""
self.master.run_command([paths.IPA_CERTUPDATE])
returncode, _data = run_healthcheck(self.master)
assert returncode == 0

def test_dogtag_ca_check_exists(self):
"""
Testcase to verify checks available in
Expand Down