Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workshop: Update docs and support default cloud image #5722

Closed
wants to merge 1 commit into from
Closed

workshop: Update docs and support default cloud image #5722

wants to merge 1 commit into from

Conversation

netoarmando
Copy link
Member

@netoarmando netoarmando commented Apr 19, 2021

Update instructions on how to build images starting with Fedora 34 using kickstart files used by Fedora to build its cloud images.

Change vagrant provisioning steps to support both prebuilt and default cloud images, removing the burden of maintaining boxes up-to-date, but also providing a way to build fresh images without external packer templates.


New Vagrant boxes available here: https://app.vagrantup.com/freeipa/boxes/freeipa-workshop/versions/20170517.01

@netoarmando netoarmando added needs review Pull Request is waiting for a review re-run Trigger a new run of PR-CI labels Apr 19, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Apr 20, 2021
@flo-renaud flo-renaud self-assigned this Apr 21, 2021
Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @netoarmando
thanks for the PR.
There are still references to the previous repo in the curriculum (for instance README.rst mentions $ git clone https://github.com/freeipa/freeipa-workshop.git but the workshop was moved to https://github.com/freeipa/freeipa/ in doc/workshop).

README.rst also instructs $ vagrant box add netoarmando/freeipa-workshop, this should be replaced with fedora/33-cloud-base.

README.facilitators also mentions the wrong box.

@rcritten
Copy link
Contributor

Would this affect someone doing a workshop at something like a conference with limited bandwidth? I think it would mean more packages need to be retrieved.

@netoarmando netoarmando changed the title workshop: Use default fedora cloud image workshop: Update docs and support default cloud image May 17, 2021
@netoarmando
Copy link
Member Author

@rcritten I changed this to support both cases, using prebuilt images as default.
@flo-renaud I've updated the documentation to fix your comments and reflect the new changes.

Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @netoarmando
please find additional inline comments

doc/workshop/building.rst Show resolved Hide resolved
doc/workshop/building.rst Outdated Show resolved Hide resolved
Update instructions on how to build images starting with Fedora 34 using
kickstart files used by Fedora to build its cloud images.

Change vagrant provisioning steps to support both prebuilt and default
cloud images, removing the burden of maintaining boxes up-to-date, but
also providing a way to build fresh images without external packer
templates.

Signed-off-by: Armando Neto <abiagion@redhat.com>
@flo-renaud
Copy link
Contributor

Re-running test_authconfig as the test timed out
I had a look at the latest changes, LGTM. ACK for when PRCI completes

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed and removed needs review Pull Request is waiting for a review labels Jun 4, 2021
@flo-renaud
Copy link
Contributor

master:

  • 584952b workshop: Update docs and support default cloud image

@flo-renaud flo-renaud closed this Jun 7, 2021
@netoarmando netoarmando deleted the update-workshop-box branch March 30, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants