-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workshop: Update docs and support default cloud image #5722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @netoarmando
thanks for the PR.
There are still references to the previous repo in the curriculum (for instance README.rst mentions $ git clone https://github.com/freeipa/freeipa-workshop.git
but the workshop was moved to https://github.com/freeipa/freeipa/ in doc/workshop).
README.rst also instructs $ vagrant box add netoarmando/freeipa-workshop
, this should be replaced with fedora/33-cloud-base.
README.facilitators also mentions the wrong box.
Would this affect someone doing a workshop at something like a conference with limited bandwidth? I think it would mean more packages need to be retrieved. |
@rcritten I changed this to support both cases, using prebuilt images as default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @netoarmando
please find additional inline comments
Update instructions on how to build images starting with Fedora 34 using kickstart files used by Fedora to build its cloud images. Change vagrant provisioning steps to support both prebuilt and default cloud images, removing the burden of maintaining boxes up-to-date, but also providing a way to build fresh images without external packer templates. Signed-off-by: Armando Neto <abiagion@redhat.com>
Re-running |
master:
|
Update instructions on how to build images starting with Fedora 34 using kickstart files used by Fedora to build its cloud images.
Change vagrant provisioning steps to support both prebuilt and default cloud images, removing the burden of maintaining boxes up-to-date, but also providing a way to build fresh images without external packer templates.
New Vagrant boxes available here: https://app.vagrantup.com/freeipa/boxes/freeipa-workshop/versions/20170517.01