IPA certauth plugin #575
Closed
IPA certauth plugin #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch depends on SSSD/sssd#192 (SSSD's certmap library) and krb5/krb5#610 (MIT Kerberos certauth plugin support) |
|
I updated the code to reflect the latest changes in the interface from krb5/krb5#610. |
ghost
self-assigned this
|
The code LGTM. Once updated SSSD is added to freeipa-master copr, let's see what CI says. Authentication indicators' handling would need to be added in a separate PR once certmap rules would provide the indicator value. |
Additionally make ipadb_find_principal public. Related to https://pagure.io/freeipa/issue/4905
This patch add a certauth plugin which allows the IPA server to support PKINIT for certificates which do not include a special SAN extension which contains a Kerberos principal but allow other mappings with the help of SSSD's certmap library. Related to https://pagure.io/freeipa/issue/4905
sumit-bose
force-pushed
the
certauth
branch
2 times, most recently
from
486a473
to
4518c60
Compare
|
I've tested the patches and it worked as expected. Once CI successfully finishes I'll ACK it. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add a certauth plugin which allows the IPA server to support
PKINIT for certificates which do not include a special SAN extension which
contains a Kerberos principal but allow other mappings with the help of
SSSD's certmap library.
Related to https://pagure.io/freeipa/issue/4905