host: try to resolve FQDN before command execution #5838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to resolve the FQDN before command execution (during pre-callback) helps detect cases where the host specified by the user does not exist, saving execution time. Aside from this, resolving the FQDN is useful when only the shortname of the host is passed, as this would cause issues when trying to update the DNS records during modification of the entry. Fixes: https://pagure.io/freeipa/issue/8726 Fixes: https://pagure.io/freeipa/issue/8884 Signed-off-by: Antonio Torres <antorres@redhat.com>
rcritten
reviewed
Jun 15, 2021
|
I toyed with a couple of other host-* commands and didn't see any need for the lookup there. Did you come to the same conclusion? |
I just added the search where it was being done before. It acts as an existence check so I think it's good to have it on top of the pre-callback function. |
|
This looks good. Can you add a test to ensure that the shortname use-cases work as expected? The xmlrpc tests would be probably the best place. |
Add test to ensure that host-mod resolves the FQDN when passing the shortname of the host being modified. Related: https://pagure.io/freeipa/issue/8726 Related: https://pagure.io/freeipa/issue/8884 Signed-off-by: Antonio Torres <antorres@redhat.com>
|
LGTM. Can you set the label for backports? I assume ipa-4-9 is sufficient. You can set ack at the same time if you want, or I can add it later. |
antoniotorresm
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve the FQDN before command execution (during
pre-callback) helps detect cases where the host specified by the user
does not exist, saving execution time. Aside from this, resolving the
FQDN is useful when only the shortname of the host is passed, as this
would cause issues when trying to update the DNS records during
modification of the entry.
Fixes: https://pagure.io/freeipa/issue/8726
Fixes: https://pagure.io/freeipa/issue/8884
Signed-off-by: Antonio Torres antorres@redhat.com