Use new method in check to prevent removal of last KRA #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcritten
force-pushed
the
issue_8397
branch
5 times, most recently
from
efd8298
to
03bce90
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It previously used a vault connection to determine if any KRA servers were installed. This would fail if the last KRA was not available. Use server roles instead to determine if the last KRA server is to be removed. https://pagure.io/freeipa/issue/8397 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Use the new role-based mechanism, one that doesn't rely on direct communication to the server, to determine whether the server being removed by `ipa server-del` contains the last KRA server. https://pagure.io/freeipa/issue/8397 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
fcami
approved these changes
Jul 21, 2021
|
Green CI run |
|
@rcritten from my PoV you can remove the temp commit to start gating instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It previously used a vault connection to determine if any
KRA servers were installed. This would fail if the last KRA
was not available.
Use server roles instead to determine if the last KRA server
is to be removed.
https://pagure.io/freeipa/issue/8397
Signed-off-by: Rob Crittenden rcritten@redhat.com