Add log messages for IP checks during client install #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
requested changes
Sep 20, 2016
| continue | ||
| root_logger.debug('IP check sucessfull: %s' % ip['addr']) | ||
| except ValueError as e: | ||
| root_logger.debug('IP check failed: %s' % str(e)) |
There was a problem hiding this comment.
I do not think we need to log success here. Btw: successful spells with two 'c' and one 'l' :)
Also, you do not need to do str(e) here as this conversion is done anyway by Python.
There was a problem hiding this comment.
It might be useful to log success as well. I decided to implement it, because it was suggested in the ticket. Will fix the typo.
Akasurde
reviewed
Sep 20, 2016
| @@ -1569,8 +1569,9 @@ def get_local_ipaddresses(iface=None): | |||
| for ip in if_addrs.get(family, []): | |||
| try: | |||
| ips.append(ipautil.CheckedIPAddress(ip['addr'])) | |||
| except ValueError: | |||
| continue | |||
| root_logger.debug('IP check sucessfull: %s' % ip['addr']) | |||
There was a problem hiding this comment.
A small nitpick - you misspelled sucessfull
The added log messages allow easier debugging of IP related issues during ipa-client-install. https://fedorahosted.org/freeipa/ticket/6331
stlaz
approved these changes
Sep 20, 2016
|
Fixed upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added log messages allow easier debugging of
IP related issues during ipa-client-install.
https://fedorahosted.org/freeipa/ticket/6331