Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FlatMapPolicy to something else #177

Closed
sockeqwe opened this issue Aug 2, 2021 · 1 comment
Closed

Rename FlatMapPolicy to something else #177

sockeqwe opened this issue Aug 2, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.0

Comments

@sockeqwe
Copy link
Collaborator

sockeqwe commented Aug 2, 2021

Since Flow and underlying flatMaps are mainly hidden from the consumer of this library it makes most likely sense to rename FlatMapPolicy to something more specific the consumer can understand better.

My Proposal would be to rename it to ExecutionPolicy:

  • FlatMapPolicy.LATEST --> ExecutionPolicy.CANCEL_PREVIOUS_EXECUTION
  • FlatMapPolicy.MERGE --> ExecutionPolicy.UNORDERED
  • FlatMapPolicy.CONCAT--> ExceutionPolicy.ORDERED

What do you think?
@sockeqwe sockeqwe added the enhancement New feature or request label Aug 2, 2021
@gabrielittner
Copy link
Member

I like it 👍

@sockeqwe sockeqwe added the good first issue Good for newcomers label Aug 16, 2021
@sockeqwe sockeqwe added this to the 1.0 milestone Sep 19, 2021
sockeqwe added a commit that referenced this issue Oct 26, 2021
@sockeqwe
Rename FlatMapPolicy to ExecutionPolicy; closes #177
dbe4062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.0
Development

No branches or pull requests
2 participants
@sockeqwe @gabrielittner