Add Apple Silicon targets #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ychescale9 Then we should be good to go here with this PR. |
ychescale9
force-pushed
the
yc/add-apple-silicon-targets
branch
from
ec5fcd3
to
7124a3f
Compare
|
@sockeqwe It's only available in the 5.0.0 milestone release, but if you don't mind we can update to |
|
@ychescale9 you are right, I overlookked that it is only available in 5.0.0 releases. Then lets keep this PR open for a bit longer and merge it in the next weeks. |
|
I think we could also remove kotest. So far we're not using it anywhere |
|
Very true 🙈 I didnt realizeit before ... Here is another PR to remove this dependency |
|
Thanks @ychescale9 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199.
Temporarily using
com.freeletics.mad:state-machine:0.3.0-SNAPSHOT(testing locally) until this merged and released.Remaining dependencies missing apple silicon targets: