This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Setup for publising #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| ```groovy | ||
| implementation 'com.freeletics.statelayout:statelayout:1.0.0' | ||
| ``` | ||
| Keep in mind that this library is written in kotlin which means you also need to add `kotlin-stdlib` to a project using StateLayout. |
There was a problem hiding this comment.
This isn't necessary. The Kotlin stdlib is a transitive dependency, there is no need for consumers to explicitly add it.
lib/build.gradle
Outdated
Comment on lines
10
to
17
| mavenPublish { | ||
| targets { | ||
| uploadArchives { | ||
| releaseRepositoryUrl = "https://oss.sonatype.org/service/local/staging/deploy/maven2/" | ||
| snapshotRepositoryUrl = "https://oss.sonatype.org/content/repositories/snapshots/" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is the default, no need to explicitly set it.
| POM_LICENCE_DIST=repo | ||
|
|
||
| POM_DEVELOPER_ID=Freeletics | ||
| POM_DEVELOPER_NAME=Freeletics |
There was a problem hiding this comment.
You could add a POM_DEVELOPER_URL that links to https://freeletics.com or https://freeletics.engineering/
gabrielittner
approved these changes
May 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.