exceptional grooming

freeorion · Dec 8, 2019 · c86a6cf · c86a6cf
1 parent f15151b
commit c86a6cf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/network/Message.cpp b/network/Message.cpp
@@ -560,7 +560,7 @@ Message DispatchCombatLogsMessage(const std::vector<std::pair<int, const CombatL
         freeorion_xml_oarchive oa(os);
         try {
             oa << BOOST_SERIALIZATION_NVP(logs);
-        } catch (std::exception e) {
+        } catch (const std::exception& e) {
             ErrorLogger() << "Caught exception serializing combat logs: " << e.what();
         }
     }

diff --git a/server/ServerApp.cpp b/server/ServerApp.cpp
@@ -966,7 +966,7 @@ void ServerApp::UpdateCombatLogs(const Message& msg, PlayerConnectionPtr player_
 
     try {
         player_connection->SendMessage(DispatchCombatLogsMessage(logs));
-    } catch (std::exception e) {
+    } catch (const std::exception& e) {
         ErrorLogger() << "caught exception sending combat logs message: " << e.what();
         std::vector<std::pair<int, const CombatLog>> empty_logs;
         player_connection->SendMessage(DispatchCombatLogsMessage(empty_logs));

diff --git a/util/Directories.cpp b/util/Directories.cpp
@@ -347,7 +347,7 @@ void InitBinDir(const std::string& argv0) {
                 problem = true;
         }
 
-    } catch (fs::filesystem_error err) {
+    } catch (...) {
         problem = true;
     }