Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nova Bomb needs sitrep #1085

Open
MatGB opened this issue Nov 4, 2016 · 0 comments
Open

Nova Bomb needs sitrep #1085

MatGB opened this issue Nov 4, 2016 · 0 comments
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator.

Comments

@MatGB
Copy link
Member

MatGB commented Nov 4, 2016

Description

If you blow up an entire star system and all of its contents, then you ought to get told, and probably everyone that can see the system ought to know about it as well.

Expected Result

When a player sets off a nova bomb, that player and all others that can see the system should get sitreps.
@MatGB MatGB added component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator. category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. labels Nov 4, 2016
@Vezzra Vezzra added this to the Next Release milestone Nov 4, 2016
@Vezzra Vezzra modified the milestones: optional for v0.4.7, v0.4.7 Feb 12, 2017
@Vezzra Vezzra modified the milestones: optional for v0.4.7, v0.4.8 May 1, 2017
@Vezzra Vezzra modified the milestones: v0.4.8 (optional), post 0.4.8 Jun 6, 2018
@Vezzra Vezzra removed this from the Next Release milestone Sep 22, 2019
@rrobgill rrobgill mentioned this issue Jun 4, 2020
Merged
geoffthemedio pushed a commit that referenced this issue Jun 13, 2020
@rrobgill
Sitrep for supernova (#3005)
ed213fb 
* Sitrep for supernova

Addressing Issue #1085 detonation of a Nova Bomb now results in sitrep
to all players that the system is visible.

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

* Adjusted text of sitrep message

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

* remove 'thriving' from text

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

* Generate SitRep message by Supernova Special, rather than by ship part.

This eliminates the problem of multiple sitreps appearing if multiple
nova bombs are simultaneously detonated

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

* Stacking group to prevent multiple sitrep messages

Generate Sitrep from nova activator

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:content scripting The Issue/PR deals with the FOCS language, turn events or the universe generator.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vezzra @MatGB