Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references due to split FOCS definition sources #1506

Conversation

dbenage-cx
Copy link
Member

Updates messages and comments missed in PR #481

Fixes #1502

@dbenage-cx dbenage-cx added category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:internal The Issue/PR deals with any project component that has no explicit `component` label. labels Apr 17, 2017
@dbenage-cx dbenage-cx added this to the post v0.4.7 milestone Apr 17, 2017
@LGM-Doyle
Copy link
Contributor

LGTM

* ShipDesign names refer to designs listed in premade_ship_designs.txt.
* fleet of ships, and a name for such a fleet, loaded from
* scripting/starting_fleets.
* ShipDesign names refer to designs listed in scripting/premade_ship_designs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these directories don't exist

Copy link
Member Author

@dbenage-cx dbenage-cx Apr 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, fixed (I've left the change in SerializeUniverse without default to avoid reformatting the whole comment block)

@dbenage-cx dbenage-cx force-pushed the fix-1502_focs_definition_source_mention branch from e90ab28 to 7b45326 Compare April 23, 2017 23:27
@dbenage-cx
Copy link
Member Author

Rebased

@geoffthemedio
Copy link
Member

untested but looks OK

@geoffthemedio geoffthemedio merged commit cad3a1b into freeorion:master Apr 25, 2017
@Vezzra Vezzra added the status:merged All relevant commits of this PR were merged into the master development branch. label Apr 25, 2017
@dbenage-cx dbenage-cx deleted the fix-1502_focs_definition_source_mention branch April 25, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tweak The PR contains insignificant code changes, like code style grooming or value tweaking. component:internal The Issue/PR deals with any project component that has no explicit `component` label. status:merged All relevant commits of this PR were merged into the master development branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants