Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - uncrustify breaks formatting for inline assembly in ATmega port #91

Closed
feilipu opened this issue Jul 17, 2020 · 2 comments
Closed

[BUG] - uncrustify breaks formatting for inline assembly in ATmega port #91

feilipu opened this issue Jul 17, 2020 · 2 comments
Assignees
@alfred2g
Labels
bug Something isn't working

Comments

@feilipu
Copy link
Contributor

feilipu commented Jul 17, 2020

Describe the bug
Uncrustify breaks formatting for inline assembly code in port.c and portmacro.h. This makes the code unreadable.

Target
ThirdParty/GCC/ATmega

Expected behavior
Human legible code.

** Current situation**
port c
portmacro h
@feilipu feilipu added the bug Something isn't working label Jul 17, 2020
@lundinc2
Copy link
Contributor

Hello @feilipu,

Thank you for submitting this report. It seems uncrustify has caused several issues. We will investigate and report back with a fix.

@alfred2g alfred2g mentioned this issue Aug 14, 2020
Merged
@alfred2g
Copy link
Contributor

Code is now looking readable to some people at least :)
closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfred2g alfred2g

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@feilipu @alfred2g @lundinc2