Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing ability trap sprites [bounty: 2 XTR] #2432

Closed
DreadKnight opened this issue Jul 18, 2023 · 1 comment · Fixed by #2433
Closed

missing ability trap sprites [bounty: 2 XTR] #2432

DreadKnight opened this issue Jul 18, 2023 · 1 comment · Fixed by #2433
Labels
abilities The issue is related to an unit ability or more artwork This issue involves creating visual assets bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer visuals Various things that easily catch the eye
Milestone
0.5 - Chimera

Comments

@DreadKnight
Copy link
Member

Abolishe's Advanced Ability is missing sprites.

Screenshot_20230718_041737

Regression probably created from PR #2422, guessing we need to duplicate the sprite and ideally modify it as well.
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye abilities The issue is related to an unit ability or more easy Good place to start if you're a new developer bounty Some amount of our token, XatteR, is offered labels Jul 18, 2023
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone Jul 18, 2023
@DreadKnight DreadKnight added the artwork This issue involves creating visual assets label Jul 18, 2023
@andretchen0 andretchen0 mentioned this issue Jul 18, 2023
Merged
@andretchen0
Copy link
Contributor

andretchen0 commented Jul 18, 2023 •
edited
Loading

guessing we need to duplicate the sprite and ideally modify it as well.

Yeah, that was it.

If there's a console.info entry that says that Phaser can't find [name of key] in cache, it's because it hasn't been loaded into Phaser.

AB now autoloads images under /assets/phaser/autoload when a game starts. It uses the file's basename (i.e., filename without the extension) as the Phaser key. (The scheme is currently outlined in /assets/README.md, for anyone coming here late.)

In this case, the key was "trap_firewall". So I duplicated /assets/phaser/autoload/units/sprites/trap_scorched_ground.png as /assets/phaser/autoload/units/sprites/trap_firewall.png to take care of it.

DreadKnight added a commit that referenced this issue Jul 18, 2023
@DreadKnight
Merge pull request #2433 from andretchen0/firewall-fix
d7fcb25 
fix: add trap_firewall graphic to autoload folder, closes #2432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abilities The issue is related to an unit ability or more artwork This issue involves creating visual assets bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer visuals Various things that easily catch the eye
Projects
None yet
Milestone
0.5 - Chimera
Development

Successfully merging a pull request may close this issue.

fix: add trap_firewall graphic to autoload folder
2 participants
@DreadKnight @andretchen0