Make compatible with Python 3 #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the `node-sass` dependency from v4.x to v5.x so it works with Python 3. Bumping `node-sass` fixes the following issue in the transitive dependency `node-gyp`, which would occur unless Python 2 is installed: ``` npm ERR! gyp ERR! configure error npm ERR! gyp ERR! stack Error: Command failed: /usr/bin/python -c import sys; print "%s.%s.%s" % sys.version_info[:3]; npm ERR! gyp ERR! stack File "<string>", line 1 npm ERR! gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3]; npm ERR! gyp ERR! stack ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ npm ERR! gyp ERR! stack SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)? npm ERR! gyp ERR! stack npm ERR! gyp ERR! stack at ChildProcess.exithandler (node:child_process:419:12) npm ERR! gyp ERR! stack at ChildProcess.emit (node:events:513:28) npm ERR! gyp ERR! stack at maybeClose (node:internal/child_process:1091:16) npm ERR! gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:302:5) npm ERR! gyp ERR! System Linux 6.1.12-arch1-1 npm ERR! gyp ERR! command "/home/claudia/.nvm/versions/node/v18.15.0/bin/node" "/home/claudia/Documents/dev/pinball/vpweb/node_modules/. bin/node-gyp" "rebuild" npm ERR! gyp ERR! cwd /home/claudia/Documents/dev/pinball/vpweb/node_modules/sharp npm ERR! gyp ERR! node -v v18.15.0 npm ERR! gyp ERR! node-gyp -v v3.8.0 npm ERR! gyp ERR! not ok ``` Python 2 has been out of support since early 2020 so several distributions such as Arch Linux don’t even carry it any more.
|
Closes #64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the
node-sassdependency from v4.x to v5.x so it works with Python 3.Bumping
node-sassfixes the following issue in the transitive dependencynode-gyp, which would occur unless Python 2 is installed:Python 2 has been out of support since early 2020 so several distributions such as Arch Linux don’t even carry it any more.