Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with Python 3 #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make compatible with Python 3 #157

wants to merge 2 commits into from

Commits on Apr 9, 2023

  1. Codify that the project requires Node v14

    @claui
    claui committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    de21c1c View commit details
    Browse the repository at this point in the history

  2. Make compatible with Python 3 

    Bump the `node-sass` dependency from v4.x to v5.x so it works with
Python 3.

Bumping `node-sass` fixes the following issue in the transitive
dependency `node-gyp`, which would occur unless Python 2 is installed:

```
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: Command failed: /usr/bin/python -c import sys; print "%s.%s.%s" % sys.version_info[:3];
npm ERR! gyp ERR! stack   File "<string>", line 1
npm ERR! gyp ERR! stack     import sys; print "%s.%s.%s" % sys.version_info[:3];
npm ERR! gyp ERR! stack                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
npm ERR! gyp ERR! stack SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?
npm ERR! gyp ERR! stack
npm ERR! gyp ERR! stack     at ChildProcess.exithandler (node:child_process:419:12)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm ERR! gyp ERR! stack     at maybeClose (node:internal/child_process:1091:16)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:302:5)
npm ERR! gyp ERR! System Linux 6.1.12-arch1-1
npm ERR! gyp ERR! command "/home/claudia/.nvm/versions/node/v18.15.0/bin/node" "/home/claudia/Documents/dev/pinball/vpweb/node_modules/.
bin/node-gyp" "rebuild"
npm ERR! gyp ERR! cwd /home/claudia/Documents/dev/pinball/vpweb/node_modules/sharp
npm ERR! gyp ERR! node -v v18.15.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok
```

Python 2 has been out of support since early 2020 so several
distributions such as Arch Linux don’t even carry it any more.
    @claui
    claui committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    21f8cc5 View commit details
    Browse the repository at this point in the history