Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add focus outline on keyboard nav for clickable card #1858

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

vegardsoerlie
Copy link
Contributor

@vegardsoerlie vegardsoerlie commented Mar 2, 2021

affects: @fremtind/jkl-card

ISSUES CLOSED: #1853

📥 Proposed changes

Add a focus outline to clickable cards

Skjermbilde 2021-03-02 kl  12 18 00

☑️ Submission checklist

  • I have read the CONTRIBUTING doc
  • yarn build works locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

affects: @fremtind/jkl-card

ISSUES CLOSED: #1853
SercanSercan
SercanSercan previously approved these changes Mar 2, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b60f840:

Sandbox Source
all-components Configuration

Copy link
Contributor

@lfbergee lfbergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bruk keyboard-navigation mixin, eller lag en ny uten touch-navigasjon.

Og når du først roter inne i denne, legg gjerne til integrasjonstest på den også :)

packages/card/card.scss Outdated Show resolved Hide resolved
affects: @fremtind/jkl-card
@lfbergee
Copy link
Contributor

lfbergee commented Mar 2, 2021

Ser bra ut, jeg er litt pedantisk å skulle vel gjerne hatt en liten squash så det bare er en commit, men gråter meg ikke i søvn om det ikke blir gjort.

@vegardsoerlie vegardsoerlie merged commit 7e38cde into master Mar 2, 2021
@vegardsoerlie vegardsoerlie deleted the focus-outline-card branch March 2, 2021 15:21
@vegardsoerlie
Copy link
Contributor Author

Ser bra ut, jeg er litt pedantisk å skulle vel gjerne hatt en liten squash så det bare er en commit, men gråter meg ikke i søvn om det ikke blir gjort.

For å ikke risikere dårlig søvn så ble det en squash+merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feil: Clickable card mangler visuelt fokus ved keyboard navigering
3 participants