-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: refactor Sass og innfør en stilguide #2868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import-syntaksen fjernes fra Sass i oktober. Vi ønsker å være litt i forkant og migrere vekk fra syntaksen i god tid før det. BREAKING CHANGE: For brukere av Sass-koden vil dere kunne oppleve breaking changes. Se MIGRATION.md. Om du importeres CSS i prosjektet ditt er det ingen breaking change.
BREAKING CHANGE: Maps fra motion er gjort private, jkl-motion er nå easing, jkl-timing er nå timing.
BREAKING CHANGE: Avhenger av ny majorversjon av core
For de som bruker Sass til å importere stilpakker, nå kan de slippe "jkl-button/button" for eksempel
Det fungerer dårlig med Sass sin string interpolation
BREAKING CHANGE: Sass-variabler, mixins og CSS-animasjoner fra pakker annet enn core er gjort private
Er ikke kutyme i SassDoc virker det som
wkillerud
added
📚 Dokumentasjon
Dokumentasjon i kodebasen, Figma eller portalen
👋 help wanted
labels
May 6, 2022
This comment was marked as outdated.
This comment was marked as outdated.
fremtind-bot
added a commit
that referenced
this pull request
May 6, 2022
Liker ikke at Gulp "bygger" uten å klage på disse importene.
This comment was marked as outdated.
This comment was marked as outdated.
fremtind-bot
added a commit
that referenced
this pull request
May 9, 2022
wkillerud
commented
May 9, 2022
This comment was marked as outdated.
This comment was marked as outdated.
fremtind-bot
added a commit
that referenced
this pull request
May 9, 2022
Det gjør det vanskeligere å søke etter navn man kjenner fra APIet utad. Det gjør det også vanskeligere for enkelte verktøy å følge koden, for eksempel Go to Definition i VS Code.
fremtind-bot
added a commit
that referenced
this pull request
May 16, 2022
Benyttet sjansen til å innføre ESLint-regler for imports for å få en diff jeg kunne tagge med breaking change i React-koden. Promoterer samtidig de siste gjenstående pakkene vi har hatt på versjon
|
BREAKING CHANGE: Pakken avhenger av en breaking versjon av core
BREAKING CHANGE: Ingen faktisk breaking change.
fremtind-bot
added a commit
that referenced
this pull request
May 18, 2022
fremtind-bot
added a commit
that referenced
this pull request
May 18, 2022
kennidenni
previously approved these changes
May 18, 2022
Det brukes bare i devserver/eksempler, ikke i selve bundlen som shippes
fremtind-bot
added a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva skjer?
Ganske mye. I forbindelse med refactor til nytt modulsystem for Sass (#2757) ønsket jeg å se grundigere på den eksisterende Sass-kodebasen. Jeg synes vi har manglet et tydelig API, og at vi har vært inkonsekvente med et par ting.
Jeg noterte med ned disse endringsforslagene tidligere i år:
@use "@fremtind/jkl-table"
for eksempeljkl
Det er helt lov å være uenig i disse forslagene. Supert også om du har andre forslag til forbedringer nå som jeg uansett er i gang med en breaking change.
End goal
Hva skal jeg mene noe om?
Minimum
Bonus
The real MVP
TODO
🎯 Sjekkliste
yarn build
ogyarn ci:test
gir ingen feil