Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: "LITE" version setting - without Timescale and GIS, just pure PostgreSQL #20

Closed
freol35241 opened this issue Jan 5, 2021 · 2 comments · Fixed by #29

Comments

@freol35241
Copy link
Owner

Would be great to add something like "LITE" version setting - without Timescale and GIS, just pure PostgreSQL. Already using your addon with some tweaked code to remove those unwanted dependecy plugins (commented few lines of code on DB creation). Thanks

Originally posted by @rds76 in #8 (comment)

@BenediktAllendorf
Copy link
Contributor

BenediktAllendorf commented Jan 5, 2022

What a coincidence! I'm just struggling with getting a simple timescaleDB + PostGIS docker image, which would be solved by this because I could just ignore PostGIS (I don't really need that).

I would be interested in helping with that.

Right now, I see two things that need to be adjusted:

  1. Only create the configured extensions (either, both, none)
  2. Handle location differently (e.g. don't save it at all? :D)

As far as I understand it, timescaledb only works "under the hood" right now - so it's faster but you can exchange it with pure Postgres without changing the code? That was not entirely correct, there is code in the setup (_setup_connection()) but not in the usage, right?

@freol35241
Copy link
Owner Author

Hi @BenediktAllendorf
I would be very happy to review a PR for this so feel free to dig in!

Some suggestions:

  • please keep the current configuration as the default (i.e. with both extensions enabled
  • without the postgis extension, location should probably just be stored in the regular attributes column (i.e. just skip the special treatment of it)
  • this needs some proper documentation in the readme with clear info about which other config options that becomes superfluous etc when disabling for example the timescaledb extension
  • i am expecting this to be a "first use only" option? So it should not be possible to add timescaledb to an existing setup initially without timescaledb (an example). This need to be very clear inte documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants