Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passkey: check account signature on passkey #2036

Merged
merged 15 commits into from
Jun 24, 2024
Merged

Passkey: check account signature on passkey #2036

merged 15 commits into from
Jun 24, 2024

Conversation

saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Jun 18, 2024 •
edited

Go after #2037

Goal

The goal of this PR is to setup functions and tests for account signature checks

Part of: #2028

Checklist

  • Chain spec updated
  • Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • Design doc(s) updated
  • Tests added
  • Benchmarks added
  • Weights updated

@saraswatpuneet saraswatpuneet changed the title [WIP] Passkey: check account signature on passkey Passkey: check account signature on passkey Jun 18, 2024
@saraswatpuneet saraswatpuneet marked this pull request as ready for review June 18, 2024 19:44
@saraswatpuneet saraswatpuneet requested review from aramikm, a team, shannonwells, mattheworris, enddynayn, claireolmstead and JoeCap08055 and removed request for a team June 18, 2024 19:44
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Files Coverage Δ
pallets/passkey/src/lib.rs 69.23% <86.36%> (+15.65%) ⬆️

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 18, 2024
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 20, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 20, 2024
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 20, 2024
@github-actions github-actions bot removed the metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented label Jun 20, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 20, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 21, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 24, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 24, 2024
mattheworris
mattheworris approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through code
  • Executed 'unit tests' (all passed)
    🚀 lgtm 🚀

aramikm
aramikm reviewed Jun 24, 2024
View reviewed changes
pallets/passkey/src/lib.rs Outdated Show resolved Hide resolved
pallets/passkey/src/lib.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 24, 2024
@saraswatpuneet saraswatpuneet enabled auto-merge (squash) June 24, 2024 18:07
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 24, 2024
@saraswatpuneet saraswatpuneet merged commit a116aa0 into main Jun 24, 2024
28 checks passed
@saraswatpuneet saraswatpuneet deleted the passkey_validation branch June 24, 2024 18:08
@aramikm aramikm mentioned this pull request Jun 28, 2024
Merged
4 tasks
aramikm added a commit that referenced this pull request Jul 3, 2024
@aramikm
passkeys: check p256 signature (#2047)
94a8ad8 
# Goal
The goal of this PR is check p256 Passkey signatures validations.

Closes #2036 


# Checklist
- [X] Chain spec updated
- [X] Tests added
- [X] Benchmarks updated
- [X] Weights updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworris mattheworris mattheworris approved these changes

@aramikm aramikm aramikm approved these changes

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@shannonwells shannonwells Awaiting requested review from shannonwells shannonwells was automatically assigned from frequency-chain/pr-reviewers

@enddynayn enddynayn Awaiting requested review from enddynayn enddynayn was automatically assigned from frequency-chain/pr-reviewers

@claireolmstead claireolmstead Awaiting requested review from claireolmstead claireolmstead was automatically assigned from frequency-chain/pr-reviewers

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saraswatpuneet @mattheworris @aramikm @JoeCap08055