Passkey types #2037
Merged
Passkey types #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramikm
commented
Jun 18, 2024
aramikm
commented
Jun 18, 2024
| /// account id which is the origin of this call | ||
| pub account_id: T::AccountId, | ||
| /// account nonce | ||
| pub account_nonce: T::Nonce, |
There was a problem hiding this comment.
We might have other fields in addition to nonce. If that was the case we might put them inside their own struct.
Codecov ReportAttention: Patch coverage is
|
github-actions
bot
added
the
metadata-changed
aramikm
requested review from
saraswatpuneet,
enddynayn,
shannonwells,
JoeCap08055,
mattheworris and
claireolmstead
| pub authenticator_data: PasskeyAuthenticatorData, | ||
| /// passkey client data in json format | ||
| pub client_data_json: PasskeyClientDataJson, | ||
| } |
saraswatpuneet
approved these changes
Jun 20, 2024
JoeCap08055
reviewed
Jun 20, 2024
6 tasks
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
mattheworris
approved these changes
Jun 21, 2024
enddynayn
reviewed
Jun 24, 2024
| } | ||
| } | ||
|
|
||
| #[pallet::validate_unsigned] |
There was a problem hiding this comment.
I believe it would be beneficial for us to merge into a feature branch. I’m not clear on why we are merging directly into the main branch, as we haven’t done this before. Could you please explain the reason for this deviation?
saraswatpuneet
added a commit
that referenced
this pull request
Jun 24, 2024
Go after #2037 # Goal The goal of this PR is to setup functions and tests for account signature checks Part of: #2028 # Checklist - [ ] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [x] Tests added - [ ] Benchmarks added - [ ] Weights updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to implement passkey types and extrinsics
Closes #2027
Discussion
Checklist