Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable jda nas for more architectures #692

Merged
merged 3 commits into from
Jul 28, 2022
Merged

enable jda nas for more architectures #692

merged 3 commits into from
Jul 28, 2022

Conversation

topi314
Copy link
Member

@topi314 topi314 commented Jul 17, 2022 •
edited
Loading

this adds jda nas support for the following architectures:

linux-x86
linux-aarch64
linux-arm
win-x86-64
win-x86
darwin

m1 support is currently missingthis has been added

@topi314 topi314 requested a review from freyacodes July 17, 2022 23:28
@topi314
Copy link
Member Author

topi314 commented Jul 17, 2022 •
edited
Loading

the tests pass on my machine 😿
image

@topi314 topi314 requested a review from devoxin July 17, 2022 23:40
@devoxin
Copy link
Member

devoxin commented Jul 18, 2022

the tests pass on my machine 😿 image

CI server fails with org.springframework.beans.BeanInstantiationException: Failed to instantiate [moe.kyokobot.koe.KoeOptions]: Factory method 'koeOptions' threw exception; nested exception is java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: /opt/buildagent/temp/buildTmp/lava-jni-natives/1658100533975/libudpqueue.so: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /opt/buildagent/temp/buildTmp/lava-jni-natives/1658100533975/libudpqueue.so)

@topi314 topi314 marked this pull request as ready for review July 18, 2022 11:05
@topi314 topi314 self-assigned this Jul 18, 2022
@freyacodes freyacodes merged commit b7c61da into dev Jul 28, 2022
@freyacodes freyacodes deleted the support-more-architectures branch July 28, 2022 08:08
@topi314 topi314 mentioned this pull request Jul 30, 2022
Closed
@topi314 topi314 mentioned this pull request Aug 28, 2022
Merged
freyacodes added a commit to freyacoded/repo-test that referenced this pull request Oct 11, 2022
@freyacodes
Merge pull request lavalink-devs#692 from freyacodes/support-more-arc…
f496e1c 
…hitectures

enable jda nas for more architectures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freyacodes freyacodes freyacodes approved these changes

@devoxin devoxin Awaiting requested review from devoxin

Assignees

@topi314 topi314

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topi314 @devoxin @freyacodes