Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Recalculate score for saved builds #170

Closed
fribbels opened this issue Mar 3, 2024 · 3 comments
Closed

[Bug] Recalculate score for saved builds #170

fribbels opened this issue Mar 3, 2024 · 3 comments
Labels
ready for release To be merged into main in the next update

Comments

@fribbels
Copy link
Owner

fribbels commented Mar 3, 2024 •
edited

Motivation

Currently the saved builds scores are static and don't update when the scoring algorithm changes

Objective

Re-apply the scoring algorithm when opening the saves builds menu. This should take into account custom scoring updates.
@fribbels fribbels changed the title Feature: Recalculate score for saved builds [Bug] Recalculate score for saved builds Mar 8, 2024
@kaixin-hc
Copy link
Contributor

i'll give this a shot!

kaixin-hc added a commit to kaixin-hc/hsr-optimizer that referenced this issue Apr 13, 2024
@kaixin-hc
fix(fribbels#170):update build scores when saved build modal opens
7e62ca5
@kaixin-hc kaixin-hc mentioned this issue Apr 13, 2024
Merged
3 tasks
@kaixin-hc
Copy link
Contributor

kaixin-hc commented Apr 13, 2024 •
edited

Transferring discord discussion here if someone finds this in the future:

The key issue here is that the two numbers don't match - and this is confusing for the user:
ss of scoring not updating

There are use cases where you might not want to update your saved build with the most recent algorithm, such as with characters who can have multiple build profiles: (see #35 for more discussion. When #35 is implemented, scores will eventually be attached to scoring profiles instead of characters. The build itself should be saved with a profile attached to it instead of the behaviour we have now in the fix)

One obvious issue with mantaining build's score based on the scoring algorithm when it was saved is the user will probably forget what their custom settings were, and it'd be a whole bunch more (out of scope) work to make a UI that makes sense for this.

so the fix for this bug is just to get the two numbers to match by updating the saved builds since "we want to score both the character and its saved builds by the current user defined scoring algorithm".

kaixin-hc added a commit to kaixin-hc/hsr-optimizer that referenced this issue Apr 14, 2024
@kaixin-hc
fix(fribbels#170):update build scores when saved build modal opens
059be3c
kaixin-hc added a commit to kaixin-hc/hsr-optimizer that referenced this issue Apr 14, 2024
@kaixin-hc
fix(fribbels#170):update build scores when saved build modal opens
461580d
fribbels pushed a commit that referenced this issue Apr 14, 2024
@kaixin-hc
fix(#170):update build scores when saved build modal opens (#284)
8f04e98
@fribbels fribbels added the ready for release To be merged into main in the next update label Apr 16, 2024
fribbels added a commit that referenced this issue Apr 18, 2024
@fribbels @Kenste
@Kamii0909 @tiffanynwyeung @khisaki @tzheliang @kaixin-hc
Update 04-18-2024 (#298)
85b8afa 
* fix: set relic owner correctly on creation (#259)

* fix: set relic owner correctly on creation

* fix(DB): consistency in DB setRelic and equipRelic

fix #184
fix relic equip logic when relic part is changed
fix relic assigning consistency

* feat(#262): add new relic modal when clicking on empty relic slot in … (#269)

* feat(#262): add new relic modal when clicking on empty relic slot in character preview

* fix(RelicPreview): do not show RelicModal in RelicScorerTab

* fix(RelicPreview): correctly edit relic when clicking on a relic

* feat: potential view with custom characters subset (#271)

* feat: better loading spinner responsiveness

* refactor: shared card seleect components

* feat: add multiselect character select

* feat: applying custom characters to potential and saving state to storage

* fix: load save with default, expand heal column to 4 digits, fix tests

* feat: reorder cols, add better tooltips

* fix: properly enable React/recommended rules (#276)

React/recommended weren't enabled in the last commit moving to flat
ESLint config. This commit re-enables it.

Co-authored-by: Hà Trung Kiên <htk0901htk@gmail.com>

* feat: add sidebar toggle, update menu text and icons, fix related tests (#277)

* Update README.md

* feat: initial implementation for leak free optimizer version (#279)

* feat: initial implementation for leak free version

* fix: officialOnly is supposed to be false

* fix: update node version to 18.19.0; remove extra 0 (#281)

There is not typically two 0's in the node version here,
and nvm-windows (maybe nvm too) complains during install.

* feat(#243): add 1000th decimal display for certain speeds (#280)

* feat(#278): add button to ScoringModal to reset all characters (#282)

* feat: use repo hosting for assets, various fixes (#283)

* refactor: extract layout components to their own files, convert to ts

* feat: clarify pioneer set wording

* fix: switch optimizer grid to click handler

* feat: half collapsed sider

* feat: add in webp assets

* revert: layout sider collapse

* feat: change cloudfront paths to local

* feat: make experiment button primary

* fix: dreary icons' base path

* feat(#275): default optimizer character on new sessions to the last selected character (#285)

* feat: default optimizer character to the last selected character (#275)

On optimizer character change, save character id into
state.savedSession.optimizerCharacterId, then read react mount.

* use saved session key constant

* feat: add the saved session character to character tab doubleclick

---------

Co-authored-by: Fribbels <fribbelsgithub@gmail.com>

* fix(#170):update build scores when saved build modal opens (#284)

* fix: remove character level selectors / other bug fixes (#288)

* feat: remove remaining references to characterLevel selectors

* fix: bug where light cone conditionals are reset to defaults when switching chars

* fix: firefox custom char modal close

* ui: adjust artist name display width and remove autocomplete

* fix: leaks-free version assets base path

* feat: add avg potential to all/custom chars (#289)

* feat: add avg potential to all/custom chars

* fix: tests

* feat: one-click optimize from relic scorer, 1000ths precision spd presets (#293)

* feat: add quick optimize button to relic scorer

* fix: herta default sort fua

* feat: 1000th precision presets

* feat: add text button, cleanup

* feat: update Getting Started tab, menu layout changes (#294)

* feat: menu layout adjustments

* feat: update Get Started tab

* fix: undo default officialOnly

* feat: 04-18-2024 update changelog (#295)

* feat: 04-18-2024 update changelog

* fix: revert official only

* fix: content width bleeding into the sidebar (#296)

* fix: load menu in a memo so officialOnly flag is set (#297)

* fix: swap the leakfree deployment branch to main

---------

Co-authored-by: Jan-Philipp <64530741+Kenste@users.noreply.github.com>
Co-authored-by: Hà Trung Kiên <67498714+Kamii0909@users.noreply.github.com>
Co-authored-by: Hà Trung Kiên <htk0901htk@gmail.com>
Co-authored-by: TY <tiffanynwyeung@gmail.com>
Co-authored-by: khisaki <139708974+khisaki@users.noreply.github.com>
Co-authored-by: Zheliang Tan <zheliangtan@gmail.com>
Co-authored-by: Hannah <59471320+kaixin-hc@users.noreply.github.com>
@fribbels
Copy link
Owner Author

Released in #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for release To be merged into main in the next update
Projects
Fribbels HSR Optimizer Kanban Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fribbels @kaixin-hc