[Feature] Clicking on empty relic slots should bring up the Add New Relic modal #262
Labels
ready for release
To be merged into main in the next update
Comments
Kenste
added a commit
to Kenste/hsr-optimizer
that referenced
this issue
Apr 7, 2024
…slot in character preview
3 tasks
fribbels
added a commit
that referenced
this issue
Apr 18, 2024
* fix: set relic owner correctly on creation (#259) * fix: set relic owner correctly on creation * fix(DB): consistency in DB setRelic and equipRelic fix #184 fix relic equip logic when relic part is changed fix relic assigning consistency * feat(#262): add new relic modal when clicking on empty relic slot in … (#269) * feat(#262): add new relic modal when clicking on empty relic slot in character preview * fix(RelicPreview): do not show RelicModal in RelicScorerTab * fix(RelicPreview): correctly edit relic when clicking on a relic * feat: potential view with custom characters subset (#271) * feat: better loading spinner responsiveness * refactor: shared card seleect components * feat: add multiselect character select * feat: applying custom characters to potential and saving state to storage * fix: load save with default, expand heal column to 4 digits, fix tests * feat: reorder cols, add better tooltips * fix: properly enable React/recommended rules (#276) React/recommended weren't enabled in the last commit moving to flat ESLint config. This commit re-enables it. Co-authored-by: Hà Trung Kiên <htk0901htk@gmail.com> * feat: add sidebar toggle, update menu text and icons, fix related tests (#277) * Update README.md * feat: initial implementation for leak free optimizer version (#279) * feat: initial implementation for leak free version * fix: officialOnly is supposed to be false * fix: update node version to 18.19.0; remove extra 0 (#281) There is not typically two 0's in the node version here, and nvm-windows (maybe nvm too) complains during install. * feat(#243): add 1000th decimal display for certain speeds (#280) * feat(#278): add button to ScoringModal to reset all characters (#282) * feat: use repo hosting for assets, various fixes (#283) * refactor: extract layout components to their own files, convert to ts * feat: clarify pioneer set wording * fix: switch optimizer grid to click handler * feat: half collapsed sider * feat: add in webp assets * revert: layout sider collapse * feat: change cloudfront paths to local * feat: make experiment button primary * fix: dreary icons' base path * feat(#275): default optimizer character on new sessions to the last selected character (#285) * feat: default optimizer character to the last selected character (#275) On optimizer character change, save character id into state.savedSession.optimizerCharacterId, then read react mount. * use saved session key constant * feat: add the saved session character to character tab doubleclick --------- Co-authored-by: Fribbels <fribbelsgithub@gmail.com> * fix(#170):update build scores when saved build modal opens (#284) * fix: remove character level selectors / other bug fixes (#288) * feat: remove remaining references to characterLevel selectors * fix: bug where light cone conditionals are reset to defaults when switching chars * fix: firefox custom char modal close * ui: adjust artist name display width and remove autocomplete * fix: leaks-free version assets base path * feat: add avg potential to all/custom chars (#289) * feat: add avg potential to all/custom chars * fix: tests * feat: one-click optimize from relic scorer, 1000ths precision spd presets (#293) * feat: add quick optimize button to relic scorer * fix: herta default sort fua * feat: 1000th precision presets * feat: add text button, cleanup * feat: update Getting Started tab, menu layout changes (#294) * feat: menu layout adjustments * feat: update Get Started tab * fix: undo default officialOnly * feat: 04-18-2024 update changelog (#295) * feat: 04-18-2024 update changelog * fix: revert official only * fix: content width bleeding into the sidebar (#296) * fix: load menu in a memo so officialOnly flag is set (#297) * fix: swap the leakfree deployment branch to main --------- Co-authored-by: Jan-Philipp <64530741+Kenste@users.noreply.github.com> Co-authored-by: Hà Trung Kiên <67498714+Kamii0909@users.noreply.github.com> Co-authored-by: Hà Trung Kiên <htk0901htk@gmail.com> Co-authored-by: TY <tiffanynwyeung@gmail.com> Co-authored-by: khisaki <139708974+khisaki@users.noreply.github.com> Co-authored-by: Zheliang Tan <zheliangtan@gmail.com> Co-authored-by: Hannah <59471320+kaixin-hc@users.noreply.github.com>
|
Released in #298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
Currently clicking on empty relic slots doesnt do anything
But users expect this to open a relic menu or something
Objective
The text was updated successfully, but these errors were encountered: