Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add a "Custom characters" option to the relic potential view, for selecting a subset of all characters to score #266

Closed
fribbels opened this issue Apr 5, 2024 · 1 comment
Labels
ready for release To be merged into main in the next update

Comments

@fribbels
Copy link
Owner

fribbels commented Apr 5, 2024

Motivation

Currently we only show All characters. Initially we also had an option for "Owned characters" but some users found that confusing. I think the best alternative is to have a separate view for "Custom characters" that selects all characters by default, and then users can choose which ones to "discard" from the subset.

Objective

Requires some cleanup first

  • Refactor the character selector and light cone selector from the Optimizer tab into one component
  • Currently they only show one option but enable a multiselect option for this component
  • Add a new button for the relics tab to customize the subset of characters and open this mutli selector character model
  • Have a new view under relic ratings to show Max potential Custom characters

Image

@fribbels fribbels added the ready for release To be merged into main in the next update label Apr 9, 2024
@fribbels
Copy link
Owner Author

Released in #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for release To be merged into main in the next update
Projects
Development

No branches or pull requests

1 participant