Cast proper types when loading resource data #87

akariv · 2016-05-18T19:41:25Z

Fixes #82

coveralls · 2016-05-18T19:42:59Z

Coverage increased (+0.02%) to 99.006% when pulling 53ee8ce on akariv:fix/resoure-iter-to-use-schema into 6ef3d7c on frictionlessdata:master.

coveralls · 2016-05-20T15:12:51Z

Coverage decreased (-0.3%) to 98.729% when pulling bc779d2 on akariv:fix/resoure-iter-to-use-schema into 6ef3d7c on frictionlessdata:master.

vitorbaptista · 2016-06-20T11:52:02Z

@akariv Is this good to go?

akariv · 2016-06-20T11:55:27Z

@vitorbaptista as far as I can tell...

coveralls · 2016-07-08T17:23:02Z

Coverage decreased (-0.3%) to 98.732% when pulling af43beb on akariv:fix/resoure-iter-to-use-schema into 2904a30 on frictionlessdata:master.

vitorbaptista · 2016-07-18T15:13:26Z

datapackage/resource.py


    def __iter__(self):
        return self

    def __next__(self):
        row = next(self._tabulator_iter)
-        return dict(zip(row.headers, row.values))
+        row = dict(zip(row.headers,row.values))


Please add a whitespace between row.headers and row.values

vitorbaptista · 2016-07-18T15:15:23Z

@akariv I'm sorry for taking so long to review this. Could you check my comments, rebase with master and push a new version? I'm hoping to merge it this week.

Fixes frictionlessdata#82

coveralls · 2016-07-18T15:33:07Z

Coverage decreased (-0.3%) to 98.731% when pulling 477f933 on akariv:fix/resoure-iter-to-use-schema into 63718d4 on frictionlessdata:master.

vitorbaptista · 2016-07-18T15:38:34Z

Thanks, @akariv!

akariv force-pushed the fix/resoure-iter-to-use-schema branch from bc779d2 to 5316e4a Compare July 8, 2016 16:58

akariv assigned vitorbaptista and zhenyab Jul 8, 2016

akariv force-pushed the fix/resoure-iter-to-use-schema branch from 5316e4a to af43beb Compare July 8, 2016 17:18

vitorbaptista reviewed Jul 18, 2016
View reviewed changes

Cast proper types when loading resource data

477f933

Fixes frictionlessdata#82

akariv force-pushed the fix/resoure-iter-to-use-schema branch from af43beb to 477f933 Compare July 18, 2016 15:27

vitorbaptista merged commit 75dac0e into frictionlessdata:master Jul 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cast proper types when loading resource data #87

Cast proper types when loading resource data #87

akariv commented May 18, 2016 •

edited by roll

coveralls commented May 18, 2016 •

edited

coveralls commented May 20, 2016 •

edited

vitorbaptista commented Jun 20, 2016

akariv commented Jun 20, 2016

coveralls commented Jul 8, 2016 •

edited

vitorbaptista Jul 18, 2016

akariv Jul 18, 2016

vitorbaptista commented Jul 18, 2016

coveralls commented Jul 18, 2016 •

edited

vitorbaptista commented Jul 18, 2016

Cast proper types when loading resource data #87

Cast proper types when loading resource data #87

Conversation

akariv commented May 18, 2016 • edited by roll

coveralls commented May 18, 2016 • edited

coveralls commented May 20, 2016 • edited

vitorbaptista commented Jun 20, 2016

akariv commented Jun 20, 2016

coveralls commented Jul 8, 2016 • edited

vitorbaptista Jul 18, 2016

Choose a reason for hiding this comment

akariv Jul 18, 2016

Choose a reason for hiding this comment

vitorbaptista commented Jul 18, 2016

coveralls commented Jul 18, 2016 • edited

vitorbaptista commented Jul 18, 2016

akariv commented May 18, 2016 •

edited by roll

coveralls commented May 18, 2016 •

edited

coveralls commented May 20, 2016 •

edited

coveralls commented Jul 8, 2016 •

edited

coveralls commented Jul 18, 2016 •

edited