Support dereferencing #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgiana-b
force-pushed
the
feature/support-dereferencing
branch
3 times, most recently
from
350f48c
to
56e5d52
Compare
|
@georgiana-b |
Merged
roll
approved these changes
Aug 3, 2017
| @@ -133,15 +133,15 @@ By default, the gem uses the standard [Data Package Schema](http://specs.frictio | |||
| The gem comes with schemas for the standard Data Package Schema, as well as the [Tabular Data Package Schema](http://specs.frictionlessdata.io/tabular-data-package/), and the [Fiscal Data Package Schema](http://fiscal.dataprotocols.org/spec/). These can be referred to via an identifier, expressed as a symbol. | |||
|
|
|||
| ```ruby | |||
| package = DataPackage::Package.new(nil, :tabular) # Or :fiscal | |||
| package = DataPackage::Package.new(nil, schema: 'tabular-data-package') # Or 'fiscal-data-package' | |||
There was a problem hiding this comment.
Removing schema argument will be in next chunk of changes? Because now it's a part of descriptor - descriptor.profile.
There was a problem hiding this comment.
Yup, that part is in #43.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Changes made in this PR:
remove support for JSON references in Schema
support for dereferencing an object's path and URL values
dereference Resource descriptor's
schemaanddialectrefactor Package class
remove unnecessary distinction between local, remote and inline Resources
I initially also developed support for JSON references, but that turned out to be useless for now. However, I pushed that code to feature/dereferencing-JSON-pointers in case it will be needed in the future.