Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated date/time definitions #23

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Conversation

roll
Copy link
Member

@roll roll commented Jan 26, 2024


Rationale

This pull request is based on comments in frictionlessdata/specs#487 and tries to apply the least invasive and non-breaking changes. It extends default datetime formatting although it keeps simple date and time.

It might be too late to remove pattern and any formats because of backward-compatibility requirements but what if we add a note that it's RECOMMENDED always use default formats (or even using SHOULD)?

Copy link

cloudflare-pages bot commented Jan 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2e3203
Status: ✅  Deploy successful!
Preview URL: https://433d69ba.datapackage.pages.dev
Branch Preview URL: https://487-clarify-datetime-field-t.datapackage.pages.dev

View logs

roll and others added 2 commits February 19, 2024 14:04
@roll
Copy link
Member Author

roll commented Feb 19, 2024

Thanks @peterdesmet! It's been updated based on your comments!

@khusmann
@ezwelty
@pwalsh
@PietrH
@nichtich
Can you please take a look -- this change is also a good candidate to be accepted. Currently, it misses only 2 votes

@roll roll added the candidate label Feb 19, 2024
@ezwelty
Copy link

ezwelty commented Feb 19, 2024

If any cannot be removed, I would add a SHOULD (not), because its use can lead to ambiguous data, which is exactly the situation a metadata spec is supposed to fix.

pattern complicates automatic parsing of the data by software tools, but at least it serves the purpose of recording an explicit format, so I would only add a (not) RECOMMENDED. To me this falls in the same category as numeric groupChar in allowing vernacular (if not globally / computationally default) formats.

@roll
Copy link
Member Author

roll commented Feb 19, 2024

@ezwelty
I would suggest adding NOT RECOMMENDED to any format on this iteration and we can increase the strictness on next iterations. Personally, I'm favour of complete removal of any non fully interoperable parts of the spec but I think that doing so step-by-step is more realistic.

@roll
Copy link
Member Author

roll commented Feb 20, 2024

Thanks!

ACCEPTED by WG (7/9)

@roll roll merged commit 1214f3f into main Feb 20, 2024
1 check passed
@roll roll deleted the 487/clarify-datetime-field-types branch February 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time formats should be more consistent and portable across platforms
3 participants