[tests,package,#19][s]: Add test_null_values_are_stripped #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sglavoie i can't merge b/c of conflicts. Can you fix these.
This is a great note. BTW you can have these in the commit messages so they get logged in the git history (makes the commits easier to understand if you do git log). |
|
@rufuspollock, this should now be good to go! 👍 Edit: I just saw that it failed, let me have a closer look. |
* Merge branch 'master' into tests/null_values_are_stripped to avoid conflicts from the other PR. * `test_no_resources_return_empty_list` created a new requirement which broke this commit.
|
@rufuspollock, now it's working again, ready to merge! |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple addition: it removes the keys that have the value
nullin a CKAN package just as it is already doing it in the same way for CKAN resources.Note: I took the liberty to rename the test from
test_null_values_are_removedtotest_null_values_are_strippedso that it matches with the name of the test we have for CKAN resources.