Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for GZIP compressed CSV files #96

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Adds support for GZIP compressed CSV files #96

merged 2 commits into from
Apr 23, 2021

Conversation

cuducos
Copy link
Contributor

@cuducos cuducos commented Apr 22, 2021

Overview

As described in #94, this PR adds support for GZIP compressed CSV files in csv.FromFile. Also, it adds an example in the examples/compressed/ directory — I used that to manually test it since I saw no testdata/ directory or any other test using file fixtures.


Please preserve this line to notify @danielfireman (lead of this repository)


This change is Reviewable

@coveralls
Copy link

coveralls commented Apr 22, 2021

Coverage Status

Coverage decreased (-1.3%) to 88.742% when pulling 18bf4c9 on cuducos:gzip into 80cddb2 on frictionlessdata:master.

Copy link
Collaborator

@danielfireman danielfireman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! Thanks a lot for this!

Could you please take a look at my small suggestion bellow?

csv/table.go Outdated Show resolved Hide resolved
Co-authored-by: Daniel Fireman <danielfireman@gmail.com>
@danielfireman danielfireman merged commit 3deb182 into frictionlessdata:master Apr 23, 2021
@danielfireman
Copy link
Collaborator

Tanks a lot, @cuducos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants