-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduled Posts - Timezone problem with datetimepicker #10691
Comments
Timezones strike again! |
Weird thing is: It is working here. |
Just to clarify. Everything works well when posting! I set the scheduled time for the post and it goes out correctly, according to my local time. Great!! What doesn't work is the time initially offered in the drop down time. It shows the server's actual system time. In my case that is 7 hours behind my local time. Example:It's 10.05 AM here (ICT Time Zone). I open the composer and see this: It shows 3.05 AM which is UTC, which is my server's system time. I then set this to 4.00 AM assuming that the post will go out in 55 minutes. But it doesn't it, it goes out immediately. If I set it to 11 AM, it does goes out 55 minutes in line with my timezone. Conclusions:
|
Do you have these problems as well when creating events? Can you check this? |
Nope. In events the drop down menu gives out local time. |
Progress report: Minimal. Looking into the code I was able to find out that the user-set timezone in your settings has absolutely no impact on the date and time picker itself. The server timezone may have had an impact on the maximum date/time that can be selected from the picker (set at On the other hand, the timezone you set in your user setting is crucial for the correct date/time to be set when submitting the form because we received the scheduled date/time as a formatted string which we assume is formatted according to the user's provided timezone. I'm going to try to change my computer timezone, see if I can make a difference, but I'd like you to check it is correctly set to the same as your user setting in Friendica as both need to be the same for both the display and the saving to work seamlessly. |
Update: I changed my computer timezone to UTC +07:00, and after a reload of the Compose page the default date/time in the picker correctly changed to what my computer clock is saying, which is Wednesday September 15th at 5:07 AM (it is Tuesday September 14th 6:07 PM on the American East Coast). So I would double-check your computer-set timezone as it is what drives the display of the default value in the picker. |
I guess we can move this to the next milestone? It seems as if this isn't a problem in the core, but a local problem, since no one else seem to be able to reproduce it? |
Yes, let's remove it from the milestone until we get more details from @AndyHee |
Thank you @MrPetovan for looking into this and sorry for the delay; I had overlooked your ping. I think you're correct that this relates to the browser. As soon as you mentioned this, I immediately recalled that my main browser has tighter security/ privacy measures. My Firefox browser is set to give out UTC regardless of my local/ system time. This a none default setting that has been recommend by some to prevent an analysis of how your IP relates to your timezone for instance. I double checked with a different browser and everything works as expected. Now this raises the issue how shall we proceed. The current design (taking the browser time) is convenient in case users move across different timezone and find themself on a different PC with the local time. Although I understand the posting time at the moment is taken from elsewhere. However. the move away from browser time is in line with a more fundamental concern of reducing identifiable information. In this view browsers should not give out a time value full-stop or at least not by default. I personally would plead for a move away from browser time. Either way, I think what would be useful would be a display near the time picker what timezone this actually is. |
Thank you for the follow-up, I agree we should use the user-set timezone information since we have it anyway, and I don't like this issue being about a discrepancy between the user-set timezone and the browser timezone because it shouldn't be depending on the browser timezone at all. Now the problem is that the Javascript time picker we use doesn't have a timezone option and can only display the time according to the browser timezone at the moment. |
Thanks for explaining this so well; I now understand the intricacy here of using JS libraries. Yes, the discrepancy between the user-set timezone and the browser timezone is a problem. It would lead to confusion in the following cases:
So a For practical purposes, I also think that a display of the current user-set timezone near the date/ time field would go a long way. This would give absolute certainty when the post will go out. I'd envisage something like this; it could even have a hyperlink to the user setting for swift adjustment for timezone travellers: If you could give me an indication whether this is realistic to implement in terms of work effort and avoiding bloat, I would open a separate feature request. |
The timezone display and the link to the settings are both fairly easy to implement. |
Great. New feature request here: #10737 |
Bug Description
The new feature for scheduling posts defaults to a time in the past.
In my case the proposed time is set to almost 7 hours in the past! This confused me as I assumed the time shown in the schedule was UTC, which didn't turn out to be the case.
Steps to Reproduce
Expected Result:
Scheduling time/ date defaults to the future.
Screenshots
Platform Info
Friendica Version: 2021.08-rc
The text was updated successfully, but these errors were encountered: