Simplify max_data parameter for Temporal::getDateTimeField in include/conversation #10715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please apply the same change to the composer page as well. Also the picker is used at other places as well, can you apply the changes there as well? |
|
In the current state this change will applied to the Composer page, I'll look for more convoluted instances. |
|
At least it should be applied here: https://github.com/friendica/friendica/blob/2021.09-rc/src/Module/Item/Compose.php#L170 |
MrPetovan
force-pushed
the
bug/10691-scheduled-date-picker-timezone
branch
from
dc673fe
to
ab11ca5
Compare
MrPetovan
force-pushed
the
bug/10691-scheduled-date-picker-timezone
branch
from
ab11ca5
to
9a0c3cc
Compare
tobiasd
added a commit
to tobiasd/friendica
that referenced
this pull request
Sep 18, 2021
tobiasd
added a commit
to tobiasd/friendica
that referenced
this pull request
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10691
No timezone information is needed at this point.
Additionally, I removed a comma that would make the current minimum PHP version supported lie. Additional commas in function parameters list is only supported from PHP 7.3 onwards. I'm happy this hasn't been reported before, it means most active Friendica admins are running at least PHP 7.3 which they absolutely should.