Display the current timezone in date time picker fields #10818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was wrongly used to set the node-wide ot user-specific timezone - It is now fully managed from the App object - Add a static variable to DateTimeFormat maintain the convenient local() method
- It was confusing and introduced complexity that wasn't worth the unclear gain
|
|
annando
approved these changes
Oct 3, 2021
This was referenced Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10691
Closes #10737
While working on this PR, I got severely side-tracked but I believe it's for the common good. The main change is the removal of the
adjustfield in theeventtable. It was confusing and unwieldy, both in the interface and in the code. Removing it made the code clearer and opens the path to an actual solution for birthdays, once we'll figure out how we're supposed to do it.The next improvement is ditching
date_default_timezone_*calls. Having the node (or currently logged user) timezone in a single place in the App enables a better control.date_default_timezone_set()is kept in a single place to avoid Warning messages on systems where no default timezone is defined in the PHP configuration.The last one is a fix for the calendar in Frio that wasn't showing the correct time for events. This is now fixed. vier was correctly showing the event times.