Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event start & end time wrongly converted in the RSS feed #10914

Closed
tobiasd opened this issue Oct 22, 2021 · 6 comments · Fixed by #11211
Closed

Event start & end time wrongly converted in the RSS feed #10914

tobiasd opened this issue Oct 22, 2021 · 6 comments · Fixed by #11211
Assignees
Milestone

Comments

@tobiasd
Copy link
Collaborator

tobiasd commented Oct 22, 2021

The RSS feed of a Friendica account contains the entries for new events in the calendar. After entering these dates in local time (e.g. CEST) the time in the RSS feed are converted to UTC - but no hint is shown that they are displayed in UTC instead of CEST.

Maybe a side effect of #10818

Steps to Reproduce

Enter the event details in local time. e.g. CEST 19:30.

grafik

Have a look in the RSS feed, which will show the event details in UTC

grafik

Expected Result:

The time for the beginning and ending of an event should be converted into the local time of the user when generating the RSS feed.

Platform Info

Friendica Version: 2021.12-dev (libranet.de)

@MrPetovan MrPetovan self-assigned this Oct 22, 2021
@MrPetovan MrPetovan added this to the 2021.12 milestone Oct 22, 2021
@MrPetovan
Copy link
Collaborator

The problem is that at the time where the time string is generated, we don't have the information of the user that created the event since we're converting a BBCode [event] tag. The easiest solution is to indicate it is GMT time, otherwise changes will have to be much more extensive.

@tobiasd
Copy link
Collaborator Author

tobiasd commented Oct 23, 2021

Yeah, I feared something alike ;-) but this is also the explanation for the used strings being in English and not the language of the account (which I think would be a reasonable thing).

@MrPetovan
Copy link
Collaborator

Translating the days/months in any language but English is possible in PHP but it requires the underlying system to have these translations installed in the OS. It would be yet another soft requirement to check on install.

@tobiasd
Copy link
Collaborator Author

tobiasd commented Oct 24, 2021

Not the days & months, well those as well, but also the strings used by Friendica for the headers of "Starts:" and "Finishes:". For the RSS feed it is useless to have the datetime format string translate-able as the translations are not applied.

@MrPetovan
Copy link
Collaborator

The labels Starts: and Finishes: will also be translated according to the Friendica node system language.

@annando
Copy link
Collaborator

annando commented Feb 4, 2022

Should we convert the event entries in the feed to the user's timezone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants